-
Notifications
You must be signed in to change notification settings - Fork 535
HDDS-12715. add integration tests for debug-replicas-verify-checksums tool #8209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
HDDS-12715. add integration tests for debug-replicas-verify-checksums tool #8209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ptlrs for working on this.
Moving cluster creation to an extension reduces duplication, but:
- test execution is still unnecessarily long, because each test class needs to start its own cluster
- the specific implementation does not allow config to be customized if needed
Please check TestOzoneIntegrationNonHA
and its parent classes for a better way to reuse a shared cluster for multiple test classes (HDDS-12183 and several later sub-tasks of HDDS-9000).
Thanks for the review @adoroszlai. With the custom extension, the cluster is created only once for both the test classes. The cluster is initialized once and stored as a static member. I had confirmed this by logging the creation of MiniOzoneCluster. Is the goal of the new approach to consolidate all tests that can reuse the same config/cluster? |
42555b8
to
68fa7bb
Compare
Hi @adoroszlai, the PR has been updated to use the existing TestOzoneIntegrationNonHA class. Could you please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ptlrs for updating the patch.
I think the PR title also needs to be updated.
...tegration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugReplicasVerify.java
Outdated
Show resolved
Hide resolved
...tegration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugReplicasVerify.java
Outdated
Show resolved
Hide resolved
...tegration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugReplicasVerify.java
Outdated
Show resolved
Hide resolved
...tegration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugReplicasVerify.java
Outdated
Show resolved
Hide resolved
...tegration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugReplicasVerify.java
Outdated
Show resolved
Hide resolved
857aae0
to
a88c216
Compare
a88c216
to
0674e6c
Compare
Please describe your PR in detail:
ozone debug replicas verify checksums
commandTestOzoneDebugShell
to use the Extension classWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12715
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/15119784564