HDDS-12809. Avoid reverse DNS lookup in check ACL #8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this break Ranger ACL check if we pass over IP rather than host name? cc @smengcl ? |
|
Is #740 related? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We noticed a 14ms delay in OM's check ACL operation.
The cause is the reverse DNS lookup for the client's hostName, it's operated by local server's DNS lookup method, when the hostname is not found, there will be a 14ms delay, and during the negative cache, the delay is gone, but after the negative cache expires, the 14ms delay appears again.
IMO, the server side can not always have the client's hostname, and it's ok to return the IP directly in checkACL, and since we do have the "InetAddress", we can invoke getHostName() when needed, and we don't need to invoke getHostName() on every client call.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12809
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Existing tests.