HDDS-11703. xcompat audit logs are overwritten #8279
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Thanks @peterxcli for the patch. Unfortunately the fix does not seem this simple.
test-old.sh is invoked as: test-all.sh -> run_test_scripts -> run_test_script -> test-old.sh
copy_results (invoked by run_test_scripts) expects Robot results in the immediate subdir, so now combined XML report and log.html are missing from the artifact:
It also hard-codes result as the result dir:
We could use $RESULT_DIR here, but RESULT_DIR from the shell script is not visible for the function (because it is executed in new shell, not source-d).
| @@ -26,5 +26,6 @@ source "${COMPOSE_DIR}/lib.sh" | |||
| # old cluster with clients: same version and current version | |||
| for cluster_version in ${old_versions}; do | |||
| export OZONE_VERSION=${cluster_version} | |||
| export RESULT_DIR="${COMPOSE_DIR}/result/xcompat/old/${cluster_version}-${current_version}" | |||
There was a problem hiding this comment.
xcompat/old can be omitted, now it is duplicated in the directory structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Audit logs are saved when shutting down Docker Compose cluster during tests. xcompat starts/stops a cluster for each version being tested. Audit logs from each run overwrite those from previous run.
We should assign a unique prefix or suffix to each run's audit logs to prevent overwrites.
For compact old:
create a subdir for each
${cluster_version}-${current_version}What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11703
How was this patch tested?
CI:
https://github.com/peterxcli/ozone/actions/runs/14438720856
compact old: