Skip to content

HDDS-11904. Fix HealthyPipelineSafeModeRule logic. #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

HDDS-11904. Fix HealthyPipelineSafeModeRule logic. #8386

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73de65c
HDDS-11904. Fix HealthyPipelineSafeModeRule logic.
May 4, 2025
0ea1b77
Addressed review comments.
May 4, 2025
4a232fc
Added unit test.
May 4, 2025
1d226f0
Log all the bad DNs and their reasons in a single line.
May 7, 2025
b9b6791
Changed log level to debug.
May 14, 2025
f008358
Merge remote-tracking branch 'apache/master' into HDDS-11904
May 14, 2025
7ae873e
Fixed Tests.
May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log all the bad DNs and their reasons in a single line.
  • Loading branch information
Aryan Gupta committed May 7, 2025
commit 1d226f0e3b39f2e2d5875c980d4c3bd3c95a0bc1
10 changes: 5 additions & 5 deletions ...er-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/HealthyPipelineSafeModeRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,11 @@ protected synchronized void process(Pipeline pipeline) {
}

if (!badDnsWithReasons.isEmpty()) {
LOG.warn("Below DNs reported by Pipeline: {} are either in bad health or un-registered with SCMs",
pipeline.getId());
for (Map.Entry<DatanodeDetails, String> entry : badDnsWithReasons.entrySet()) {
LOG.warn("DN {}: {}", entry.getKey().getID(), entry.getValue());
}
String badDnSummary = badDnsWithReasons.entrySet().stream()
.map(entry -> String.format("DN %s: %s", entry.getKey().getID(), entry.getValue()))
.collect(Collectors.joining("; "));
LOG.warn("Below DNs reported by Pipeline: {} are either in bad health or un-registered with SCMs. Details: {}",
pipeline.getId(), badDnSummary);
return;
}

Expand Down