HDDS-12854. Remove unused POM properties #8394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
May 6, 2025
jojochuang
reviewed
May 6, 2025
| @@ -212,15 +207,13 @@ | |||
| <slf4j.version>2.0.17</slf4j.version> | |||
| <snakeyaml.version>2.0</snakeyaml.version> | |||
| <snappy-java.version>1.1.10.7</snappy-java.version> | |||
| <sonar.java.binaries>${basedir}/target/classes</sonar.java.binaries> | |||
There was a problem hiding this comment.
we would still need this one for SonarQube analysis: https://docs.sonarsource.com/sonarqube-server/latest/analyzing-source-code/languages/java/
jojochuang
reviewed
May 6, 2025
| <errorprone-annotations.version>2.29.2</errorprone-annotations.version> | ||
| <!-- test groups excluded by default (without any manual profile activation) --> | ||
| <excluded-test-groups>unhealthy</excluded-test-groups> | ||
| <exec-maven-plugin.version>3.5.0</exec-maven-plugin.version> | ||
| <failIfNoTests>false</failIfNoTests> |
There was a problem hiding this comment.
this is used by surefire but the default is false. So it's fine to remove it.
jojochuang
reviewed
May 6, 2025
| @@ -189,7 +185,6 @@ | |||
| <project.build.outputTimestamp>2025-03-12T22:12:52Z</project.build.outputTimestamp> | |||
| <!-- platform encoding override --> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
There was a problem hiding this comment.
this is used by Maven itself. Is it UTF-8 by default? I'm not finding a reference for the default value.
|
/pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-12854 Remove unused root pom.xml properties
Please describe your PR in detail:
Removed unused properties in pom.xml
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12854
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)