Skip to content

HDDS-13013. [Snapshot] Add metrics and tests for snapshot operations. #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-13013. [Snapshot] Add metrics and tests for snapshot operations.

Please describe your PR in detail:

  • Add metrics counter for renameSnapshot, cancelSnapshotDiff, listSnapshotDiffJobs requests.
  • update the counters in the respective request handlers.
  • Tests to ensure the counters are updated correctly after each operation: including listSnapshotDiffJobs, cancelSnapshotDiff, getSnapshotInfo, renameSnapshot, deleteSnapshot

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13013

(Please replace this section with the link to the Apache JIRA)

How was this patch tested?

New unit tests TestOmMetrics#testSnapshotOps()

@jojochuang jojochuang added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label May 12, 2025
@jojochuang
Copy link
Contributor Author

cc @SaketaChalamchala

@adoroszlai adoroszlai marked this pull request as draft May 13, 2025 15:20
@adoroszlai adoroszlai marked this pull request as ready for review May 13, 2025 18:21
@jojochuang jojochuang requested review from sadanand48 and smengcl May 20, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snapshot https://issues.apache.org/jira/browse/HDDS-6517
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants