Skip to content

HDDS-8781. Allow on demand metadata scanning of open containers #8442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tejaskriya
Copy link
Contributor

What changes were proposed in this pull request?

Currently on demand scanning does a full check (data and metadata) of closed containers only. Data scan of blocks can only be done on closed containers, but metadata scan can be done on open containers. When an open container is queued for on-demand scanning, the scanner should do a metadata scan instead of ignoring it.
This PR introduces metadata scan for open containers as well.

What is the link to the Apache JIRA

HDDS-8781

How was this patch tested?

Updated existing unit and integration tests

@Tejaskriya Tejaskriya requested a review from errose28 May 13, 2025 14:01
@adoroszlai adoroszlai marked this pull request as draft May 13, 2025 15:05
@adoroszlai adoroszlai marked this pull request as ready for review May 13, 2025 20:48
Copy link
Contributor

@aryangupta1998 aryangupta1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good to me!
Some minor comments inline.

@errose28 errose28 added the scanners Changes related to datanode container and volume scanners label May 19, 2025
@Tejaskriya
Copy link
Contributor Author

Thanks for the review @aryangupta1998 , I have addressed all the changes you have suggested

@Tejaskriya Tejaskriya requested a review from aryangupta1998 May 22, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scanners Changes related to datanode container and volume scanners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants