HDDS-8049. [snapshot] Support snapshot generation through 'ozone freon'. #8483
+187
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I3df34082617971d72934c2a8003f47a7d8a51f8a
sadanand48
reviewed
May 21, 2025
| for (int dirIndex = 1; dirIndex <= numDirs; dirIndex++) { | ||
| String dirName = String.format("dir-%d", dirIndex); | ||
| // Append "/" to denote a directory. | ||
| bucket.createKey(dirName + "/", 0).close(); |
There was a problem hiding this comment.
nit: can use bucket.createDirectory(String dirName) too
sadanand48
reviewed
May 21, 2025
Change-Id: I658e663d9e24681731278747ce836d787c551353
| @Option(names = {"--dirs"}, | ||
| description = "Number of directories to create after each snapshot", defaultValue = "5") | ||
| private int numDirs; | ||
|
|
There was a problem hiding this comment.
Thanks for the patch @jojochuang. Should we also have an option to generate keys --keys?
Comment on lines
+84
to
+85
| // Snapshot creation: this is a placeholder call. | ||
| // Replace this call with the actual snapshot creation method supported in your environment. |
There was a problem hiding this comment.
Suggested change
| // Snapshot creation: this is a placeholder call. | |
| // Replace this call with the actual snapshot creation method supported in your environment. | |
| // Create snapshot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-8049. [snapshot] Support snapshot generation through 'ozone freon'.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8049
How was this patch tested?
TestSnapshotGenerator verifies that the expected number of snapshots are created.
https://github.com/jojochuang/ozone/actions/runs/15123732084