HDDS-13054. [DiskBalancer] Stop DiskBalancer when DN enters DECOMMISSIONING or MAINTENANCE states #8488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssiong and maintenance of DN
chungen0126
reviewed
May 21, 2025
...rc/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
May 28, 2025
...rc/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
May 28, 2025
...zone/container/common/statemachine/commandhandler/SetNodeOperationalStateCommandHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When DN enters in DECOMMISSIONING or MAINTENANCE states, DiskBalancer on that DN should be stopped and resume again after DN turns to normal state. This needs to be fixed.
This JIRA also tracks the addition of integration tests to validate DiskBalancer's behaviour when a DataNode (DN) transitions into DECOMMISSIONING or MAINTENANCE states.
Test Scenarios: When DiskBalancer is running mark one DN as Decommissioned and other as Maintenance.
Setup: Create a cluster with 5 DNs, each having multiple data volumes.
Description: Start DiskBalancer on all DNs. While it's actively balancing, decommission one of the DNs and mark other DN state as Maintenance.
Expected Behaviour:
Disk balancer should pause itself if the DN state is maintenance or decomissioning, decomissioned.
DN status marked as STOPPED and should not include the decommissioned DataNode in the output of diskbalancer status and report.
Other active DataNodes should continue balancing without disruption.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13054
How was this patch tested?
Added Integration Test
TestDiskBalancerDuringDecommissionAndMaintenance