-
Notifications
You must be signed in to change notification settings - Fork 537
HDDS-13075. Fix default value in description of container placement policy configs #8511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mpl and ozone.scm.container.placement.ec.impl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreejasahithi Thanks for the patch, Please find below comments.
Also please update default value in code with SCMContainerPlacementRackAware
.
@@ -928,7 +928,7 @@ | |||
The full name of class which implements | |||
org.apache.hadoop.hdds.scm.PlacementPolicy. | |||
The class decides which datanode will be used to host the container replica in EC mode. If not set, | |||
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default | |||
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRackAware will be used as default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCMContainerPlacementRackScatter
will be used as default.
@@ -915,8 +915,8 @@ | |||
<description> | |||
The full name of class which implements | |||
org.apache.hadoop.hdds.scm.PlacementPolicy. | |||
The class decides which datanode will be used to host the container replica. If not set, | |||
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default | |||
The class decides which datanode will be used to host the container replica. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep "If not set,"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sreejasahithi.
Can we remove this TODO now that we've changed the default placement policy for EC?
Lines 65 to 69 in fff80fc
// TODO: Change default placement policy for EC | |
final Class<? extends PlacementPolicy> placementClass = conf | |
.getClass(ScmConfigKeys.OZONE_SCM_CONTAINER_PLACEMENT_EC_IMPL_KEY, | |
OZONE_SCM_CONTAINER_PLACEMENT_EC_IMPL_DEFAULT, | |
PlacementPolicy.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @sreejasahithi for the patch, @ashishkumar50, @sarvekshayr for the review. |
What changes were proposed in this pull request?
The description of
ozone.scm.container.placement.impl
andozone.scm.container.placement.ec.impl
has been updated to show that the default property used isSCMContainerPlacementRackAware
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13075
How was this patch tested?
https://github.com/sreejasahithi/ozone/actions/runs/15186737895