HDDS-13075. Fix default value in description of container placement policy configs #8511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpl and ozone.scm.container.placement.ec.impl
ashishkumar50
requested changes
May 27, 2025
There was a problem hiding this comment.
@sreejasahithi Thanks for the patch, Please find below comments.
Also please update default value in code with SCMContainerPlacementRackAware.
| @@ -928,7 +928,7 @@ | |||
| The full name of class which implements | |||
| org.apache.hadoop.hdds.scm.PlacementPolicy. | |||
| The class decides which datanode will be used to host the container replica in EC mode. If not set, | |||
| org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default | |||
| org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRackAware will be used as default | |||
There was a problem hiding this comment.
SCMContainerPlacementRackScatter will be used as default.
| @@ -915,8 +915,8 @@ | |||
| <description> | |||
| The full name of class which implements | |||
| org.apache.hadoop.hdds.scm.PlacementPolicy. | |||
| The class decides which datanode will be used to host the container replica. If not set, | |||
| org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom will be used as default | |||
| The class decides which datanode will be used to host the container replica. | |||
There was a problem hiding this comment.
Please keep "If not set,"
sarvekshayr
reviewed
May 28, 2025
There was a problem hiding this comment.
Hi @sreejasahithi.
Can we remove this TODO now that we've changed the default placement policy for EC?
sarvekshayr
approved these changes
May 28, 2025
|
Thanks @sreejasahithi for the patch, @ashishkumar50, @sarvekshayr for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The description of
ozone.scm.container.placement.implandozone.scm.container.placement.ec.implhas been updated to show that the default property used isSCMContainerPlacementRackAwareWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13075
How was this patch tested?
https://github.com/sreejasahithi/ozone/actions/runs/15186737895