HDDS-13124. Respect config hdds.datanode.use.datanode.hostname when reading from datanode #8518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
May 28, 2025
peterxcli
approved these changes
May 28, 2025
|
Thanks @KochankovID for the patch, @peterxcli for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the use of host name datanodes when working with ozone for selecting
Please describe your PR in detail:
This PR introduces an optional configuration to use DataNode hostnames instead of IP addresses for gRPC connections in Ozone.
Key changes:
Modified XceiverClientGrpc.java to check configuration HDDS_DATANODE_USE_DN_HOSTNAME and use either hostname or IP address when creating gRPC channels
Updated debug logging to show hostname information
The change provides more flexibility in environments where hostname-based identification is preferred over IP addresses. This can be particularly useful in dynamic environments where IP addresses might change but hostnames remain consistent.
https://issues.apache.org/jira/browse/HDDS-13124
How was this patch tested?
unit tests, manual tests, workflow run on the fork git repo