Add SVG Cloned Element Handling #2622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Scans the SVG for any <use> element (a clone) and replaces it with its original source element. Adds the cloned element's "transform" attribute so that its replacement inherits all its position and scaling. - Adds application Setting to toggle Clone Replacment, defaulting to OFF. Note: The <use> element in SVG is a powerful mechanism for reusing existing graphics without duplicating code. It works by referencing another SVG element—like a <cirle>, <g>, <path> etc via its ID and rendering a copy at a new location.
In the presumably ultra rare occasion, raise a log message when an infinite element loop (or clone nesting deeper than 20) is detected in the SVG. Then, mark the element as a dead end so it is not attempted to be traversed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for importing SVGs with cloned elements and properly manifesting them as objects (vs. dropping them).
<use>element (a clone) and replaces it with its original source element. Adds the cloned element's "transform" attribute so that its replacement inherits all its position and scaling.xlink:hreforhref.Note:
The
<use>element in SVG is a mechanism for reusing existing graphics without duplicating code. It works by referencing another SVG element—like a<circle>,<g>,<path>etc via its ID andxlink:hreforhrefattribute and rendering a copy at a new location. See Mozilla Documentation on elementSample SVG with Clones
Settings Screen Update