-
-
Notifications
You must be signed in to change notification settings - Fork 26
Adding swap_divergence flag #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hqkhan
That looks good.
I've let 2 style comments, and do you think you can add you a test case in formatter_test.go in which divergences strings are swapped, please?
Thank you
Thanks for the review! Yes, I will add a test and also update README to make the option more visible. |
Of course! Yes good catch about the readme, that'd be nice. |
arl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the extensive testing 👍
But i forgot to ask you, sorry my bad, can you add swap_divergence: false with a doc string to the default config in gitmux.yml (at project root).
Absolutely, will do |
arl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you
Purpose
Adding
swap_divergenceoption to allow users to customize whether "upstream behind count" should be displayed first or "upstream ahead count".Main motivation behind this was that I use
gitmuxin conjunction withlazygit. Lazygit's branch menu always showsaheadcount first followed bybehindcount. I thought it'd be nice to be able to sync them up.swap_divergence: false:swap_divergence: true:Approach
Added
swap_divergenceboolean flag for yaml file. Instead of appending to the returned stringsright away, savingaheadandbehindstrings in separate vars then appending to original stringsbased onswap_divergenceflag.Thank you!