Cockpit: add support for KVM management

[igorpecovnik]

Description

• install libvirt by default
• dynamically add bridge interfaces to libvirt
• improve documentation

Implementation Details

apt install

Testing Procedure

• Importing KVM image to the Cockpit via WEB interface
• Install / remove

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have ensured that my changes do not introduce new warnings or errors
• No new external dependencies are included
• Changes have been tested and verified
• I have included necessary metadata in the code, including associative arrays

[Tearran]

perhaps a separate module for dnsmasq? #354

[igorpecovnik]

Yeah, that might be handy. I didn't check if there are any problems coming from default installation. Still working on it.

[coderabbitai]

Walkthrough

The update introduces a new feature parameter size into the module_armbian_kvmtest function. A local variable is initialized with a default value of 10 using the construct local size="${size:-10}". This change replaces the previously hardcoded disk image expansion value of +10G with a dynamic value +"${size}"G, allowing the disk size to be adjusted based on user input. The overall logic of the script remains unchanged aside from this enhancement, ensuring that the addition is integrated without altering the existing functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

tools/modules/system/module_armbian_kvmtest.sh (2)

21-26: Add support for the new 'size' parameter in command-line parsing.

The loop now includes size along with the other features. This enhancement allows users to dynamically specify the disk expansion size. Consider validating that the provided value is numeric and re-evaluating the use of eval for assigning parameters to improve security.

🧰 Tools

🪛 Shellcheck (0.10.0)

[error] 22-22: Double quote array expansions to avoid re-splitting elements.

(SC2068)

---

[warning] 24-24: Quote the right-hand side of == in [[ ]] to prevent glob matching.

(SC2053)

---

40-40: Correct the inline comment for the 'size' variable.

The line local size="${size:-10}" initializes the disk expansion size with a default of 10 GB. However, the comment incorrectly states "number of instances". Please update the comment to accurately reflect its purpose (e.g., "default disk expansion size in GB").

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c0287c and 4bb8dc4.

📒 Files selected for processing (1)

• tools/modules/system/module_armbian_kvmtest.sh (3 hunks)

[igorpecovnik]

deprecated, closing.