Skip to content

Frontend for armbian-install as a armbian-config module #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 20, 2025

Description

Starting partitioner to which we will attach install functions. This is at POC level, design is unfinished, just few helper functions ATM.

Refference: AR-2598

Implementation Details

For now front-end design only.

image

image

Documentation Summary

Testing Procedure

sudo bash module_partitioner.sh run

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Jan 20, 2025
@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Jan 20, 2025
@igorpecovnik igorpecovnik force-pushed the partitioner branch 28 times, most recently from 9ef36ab to 388a13d Compare January 21, 2025 08:37
@igorpecovnik igorpecovnik force-pushed the partitioner branch 21 times, most recently from fe980be to e4025f0 Compare January 22, 2025 20:02
@igorpecovnik igorpecovnik changed the title Module partitioner: frontend for new armbian-install Module armbian-install: develop it from scratch as a module Jan 23, 2025
@igorpecovnik igorpecovnik changed the title Module armbian-install: develop it from scratch as a module Frontend for armbian-install as a armbian-config module Jan 30, 2025

function module_partitioner() {
local title="Partitioner"
local condition=$(which "$title" 2>/dev/null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this construction for? What does it test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am copy pasting this from template. @Tearran made this design.

Copy link
Member

@Tearran Tearran Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example, was from software title module_webmin.sh

	local title="webmin"
	local condition=$(which "$title" 2>/dev/null)

which (Binary name), True if NOT NULL
I am not familiar enough with docker to say for sure, assuming something like this.

# Check if a Docker container with a specific name is running
local title="my_container"
local condition=$(docker ps --filter "name=$container_name" --format "{{.Names}}" | grep "^$container_name$")
check)
   if [ -n "$condition" ]; then
     echo "Container $container_name is running."
   else
     echo "Container $container_name is not running."
   fi
;;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to check webmin in the system, but then it doesn't make sense to check Partitioner in the system)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then it doesn't make sense to check Partitioner in the system

(My) code sometimes makes no sense. Sorry. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry. i was just trying to figure out a new set of scripts)

Copy link
Contributor

coderabbitai bot commented Apr 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants