-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Flake.nix corrected main #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Flake.nix corrected main #5600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzdave
approved these changes
Nov 6, 2025
Collaborator
|
hi @hencjo can you do the DCO thing so we can get this in? |
Running `nix run` on a clean checkout would build and then fail because `goose-cli` could not be found. It can't be found because it's actually named just `goose`. This fixes running `nix run github:block/goose` or `nix run` on a local copy of the source. Nix flake defaults to running `goose-cli`, this patch changes that to `goose` (which matches the built binary). Signed-off-by: Henrik Sjöstrand <[email protected]>
a3bb172 to
3ce18cb
Compare
Contributor
Author
|
I think it's done. Thanks for your patience. I don't do this very often :D. |
Rodriguespn
pushed a commit
to Rodriguespn/goose
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Henrik Sjöstrand <[email protected]> Co-authored-by: Henrik Sjöstrand <[email protected]> Signed-off-by: Pedro Rodrigues <[email protected]>
Rodriguespn
pushed a commit
to Rodriguespn/goose
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Henrik Sjöstrand <[email protected]> Co-authored-by: Henrik Sjöstrand <[email protected]> Signed-off-by: Pedro Rodrigues <[email protected]>
tiensi
added a commit
to tiensi/goose
that referenced
this pull request
Nov 11, 2025
* main: (83 commits) silence copilot on minor text issues (block#5665) fix: disallow runaway subagent chains (block#5659) chore: remove usage of non-existent env var for log dir (block#5658) clarify agent instructions (block#5655) feat: add check-everything for unified style checks (block#5650) Show errors on failure (block#5643) custom instructions for copilot reviews (block#5646) fix: prevent repeated 404 errors when accessing deleted sessions (block#5644) Flake.nix corrected main (block#5600) fix: goose recipe list can return duplicated entries (block#5645) fix: bedrock creds refresh (block#5599) Fix Claude Code provider to default to Auto mode (block#5638) (block#5642) Scheduler cleanup (block#5571) Better search paths and handling of CLI providers (block#5554) docs: description required for "Add Extension" in cli - phase 2 (block#5635) Remove some logging (block#5631) Use session IDs as task IDs for subagents instead of UUIDs (block#5398) Fix the naming (block#5628) fix: default tetrate model is broken, replace with haiku-4.5 (block#5535) (block#5587) Fetch less and use the right SHA (block#5621) ...
michaelneale
added a commit
that referenced
this pull request
Nov 11, 2025
* main: silence copilot on minor text issues (#5665) fix: disallow runaway subagent chains (#5659) chore: remove usage of non-existent env var for log dir (#5658) clarify agent instructions (#5655) feat: add check-everything for unified style checks (#5650) Show errors on failure (#5643) custom instructions for copilot reviews (#5646) fix: prevent repeated 404 errors when accessing deleted sessions (#5644) Flake.nix corrected main (#5600) fix: goose recipe list can return duplicated entries (#5645) fix: bedrock creds refresh (#5599)
Surendhar-N-D
pushed a commit
to Surendhar-N-D/goose
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Henrik Sjöstrand <[email protected]> Co-authored-by: Henrik Sjöstrand <[email protected]>
arul-cc
pushed a commit
to arul-cc/goose
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Henrik Sjöstrand <[email protected]> Co-authored-by: Henrik Sjöstrand <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Henrik Sjöstrand <[email protected]> Co-authored-by: Henrik Sjöstrand <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
nix run(nix-flake mainProgram).Running
nix runon a clean checkout would build and then fail becausegoose-clicould not be found. It can't be found because it's actually named justgoose.This fixes running
nix run github:block/gooseornix runon a local copy of the source. Nix flake defaults to runninggoose-cli, this patch changes that togoose(which matches the built binary).Type of Change
AI Assistance
No AI used.
Testing
I ran
nix runlocally. And that passes :D.Email: [email protected]