Add streaming support to bedrock provider #6248
Open
+773
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @cronus42 . Looks like documentation/TODO-BEDROCK.md is a goose artifact |
Author
|
removed the doc, the tests pass when a valid credential is present in the environment with bedrock access. This was assisted by claude and I am not a rust dev, but I am a dev whose trying to be responsible with it. |
- Implemented stream() method in BedrockProvider - Set supports_streaming() to return true - Updated Cargo.toml to use futures and async-stream with proper features - Refactored provider tests
commit 3c1e12f Author: Cronus <[email protected]> Date: Mon Dec 22 11:04:34 2025 -0800 WIP: package-lock and planning docs commit eef2aec Author: Cronus <[email protected]> Date: Sun Dec 21 14:06:35 2025 -0800 Add streaming support for Bedrock provider - Implemented stream() method in BedrockProvider - Set supports_streaming() to return true - Updated Cargo.toml to use futures and async-stream with proper features - Refactored provider tests # Conflicts: # crates/goose/src/providers/bedrock.rs # crates/goose/tests/providers.rs
- Implemented stream() method in BedrockProvider - Set supports_streaming() to return true - Updated Cargo.toml to use futures and async-stream with proper features - Refactored provider tests
Signed-off-by: Adrian Cole <[email protected]>
Contributor
|
looks like your DCO check is failing! Here's how to fix it: https://github.com/block/goose/pull/6248/checks?check_run_id=58942416145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add streaming support to bedrock provider
Type of Change
AI Assistance
Testing
Tested on debian linux