chore: refactor format_messages in databricks.rs to reduce line count #6275
+118
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract helper functions from the 210-line format_messages function: - format_text_content: handles text content with image path detection - format_tool_response: handles tool response message conversion The format_messages function is now 110 lines, well under the 200 line target.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the format_messages function in databricks.rs to reduce complexity by extracting two helper functions: format_text_content for handling text content with image path detection, and format_tool_response for handling tool response message conversion. The refactoring reduces the line count from 210 to 110 lines while maintaining existing functionality.
Key Changes:
- Extracted
format_text_contenthelper to handle text content and image path detection - Extracted
format_tool_responsehelper to process tool response messages - Simplified and reformatted several JSON construction blocks for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
format_messagesfunction incrates/goose/src/providers/formats/databricks.rsto reduce its line count from 210 lines to 110 lines.Changes
Extracted two helper functions:
format_text_content: Handles text content with image path detectionformat_tool_response: Handles tool response message conversionTesting
cargo fmtappliedTask
Fixes TSK-706: Fix too_many_lines: format_messages (210 lines)