Skip to content

Conversation

@Anime-pdf
Copy link
Contributor

I was working on personal project that included DPP and Asio, and DPP was defining poll that was clashing with asio's asio::details::scheduler::poll method, so I decided to remove it, I'm not sure how compat layers usually done in such project, so this is just my vision

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2025

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit c27fa5f
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/688a9d0cc5a9860009906c3f
😎 Deploy Preview https://deploy-preview-1468--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jul 30, 2025
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@Anime-pdf
Copy link
Contributor Author

mb, forgor to include <poll.h> lol 💀

@Anime-pdf Anime-pdf requested a review from braindigitalis July 31, 2025 18:40
@braindigitalis braindigitalis merged commit 9454571 into brainboxdotcc:dev Aug 1, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants