Skip to content

Conversation

@Anime-pdf
Copy link
Contributor

Support for Server Tags

Pretty simple and straightforward. The only thing I'm unsure about, identity_enabled's description mentions some possible null value, but judging by bool_not_null it will default to false in that case, which is right behavior in my opinion

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Aug 18, 2025
@netlify
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 83fe6a4
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68a592eeb0286700089917ba
😎 Deploy Preview https://deploy-preview-1477--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only blocking on the constructor.

For the repetitive json lookups i'll pretend it doesn't exist for now

@Mishura4 Mishura4 dismissed their stale review August 18, 2025 20:49

Good to go with latest change, I can't approve the json stuff but i'll let it slide 🙈

@Anime-pdf
Copy link
Contributor Author

Anime-pdf commented Aug 20, 2025

By the way, there is dpp::user and dpp::user_identified, comment states it separates fields by oauth scope, but in discord api docs, everything except verified and email requires identify score right now. Ref

Is in-code stuff mismatched with docs intended or...?

@Mishura4
Copy link
Member

Mishura4 commented Sep 5, 2025

@braindigitalis ping

@braindigitalis braindigitalis merged commit 6915904 into brainboxdotcc:dev Sep 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants