-
-
Notifications
You must be signed in to change notification settings - Fork 193
feat: server tags support #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mishura4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only blocking on the constructor.
For the repetitive json lookups i'll pretend it doesn't exist for now
Co-authored-by: Miuna <[email protected]>
Good to go with latest change, I can't approve the json stuff but i'll let it slide 🙈
|
By the way, there is Is in-code stuff mismatched with docs intended or...? |
|
@braindigitalis ping |
Support for Server Tags
Pretty simple and straightforward. The only thing I'm unsure about,
identity_enabled's description mentions some possible null value, but judging bybool_not_nullit will default to false in that case, which is right behavior in my opinionCode change checklist