-
-
Notifications
You must be signed in to change notification settings - Fork 193
feat: add field attachment_size_limit to dpp::interaction #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add field attachment_size_limit to dpp::interaction #1478
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Looks good to me, thanks for the contribution! |
|
oops, seems ive introduced an initialisation ordering warning, should i fix it? |
|
For sure |
|
Thanks for checking 👀 I'm now wondering why we don't have it set as error |
|
Alright! Well im glad at least i found something... also rip the macos build at least that error isn't me |
braindigitalis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only thing to change is the defines
|
I'm unsure about size_t here, although as it is only ever compared against another size_t (and is a constant) i used it |
braindigitalis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look fine to me now
Add the field attachment_size_limit to dpp::interaction, allowing all interactions to have the current response attachment size limit in bytes
Code change checklist