Skip to content

Conversation

@usyless
Copy link
Contributor

@usyless usyless commented Sep 4, 2025

Add the field attachment_size_limit to dpp::interaction, allowing all interactions to have the current response attachment size limit in bytes

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Sep 4, 2025
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2025

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit efda227
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68bf18f643edcf000893f357
😎 Deploy Preview https://deploy-preview-1478--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mishura4
Copy link
Member

Mishura4 commented Sep 4, 2025

Looks good to me, thanks for the contribution!

@usyless
Copy link
Contributor Author

usyless commented Sep 4, 2025

oops, seems ive introduced an initialisation ordering warning, should i fix it?

@Mishura4
Copy link
Member

Mishura4 commented Sep 4, 2025

For sure

@Mishura4
Copy link
Member

Mishura4 commented Sep 4, 2025

Thanks for checking 👀 I'm now wondering why we don't have it set as error

@usyless
Copy link
Contributor Author

usyless commented Sep 4, 2025

Alright! Well im glad at least i found something... also rip the macos build at least that error isn't me

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only thing to change is the defines

@usyless
Copy link
Contributor Author

usyless commented Sep 5, 2025

I'm unsure about size_t here, although as it is only ever compared against another size_t (and is a constant) i used it

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look fine to me now

@braindigitalis braindigitalis merged commit 6fe9405 into brainboxdotcc:dev Sep 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants