Skip to content

Conversation

@Henonicks
Copy link
Contributor

D++ didn't support the Voice Channel Effect Send event until now.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Sep 30, 2025
@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3b66f6a
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68dedda1ff8ba6000887f16d
😎 Deploy Preview https://deploy-preview-1488--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Henonicks
Copy link
Contributor Author

Also, whoever's reviewing this, in the Discord server I've brought up removing the :s from this line:

return ":" + std::string{name} + ":";

As this is only done when the emoji doesn't have an ID. Therefore, it only adds the colons to unicode emojis and turns this:
🦆
Into this:
:🦆:
I'm willing to remove the colons, I just need someone to greenlight the decision.

@Jaskowicz1 Jaskowicz1 changed the title Added a handler for the Voice Channel Effect Send event feat: Added a handler for the Voice Channel Effect Send event Sep 30, 2025
@Jaskowicz1
Copy link
Contributor

Renamed the title to comply with code convention

@Henonicks
Copy link
Contributor Author

Renamed the title to comply with code convention

I forgot about that, my bad

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple IDE silly things

@Jaskowicz1
Copy link
Contributor

I was going to write about voice_channel_effect constructor not initialising emoji, but it seems we do that in other places too (see

activity::activity(const activity_type typ, const std::string& nam, const std::string& stat, const std::string& url_) :
).

Not sure if this is something we want to address now and go through later to sort, or if this is just something to ignore @braindigitalis @Mishura4?

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to make my previous comment an approval, whoops

@Jaskowicz1 Jaskowicz1 merged commit 7ca7a0e into brainboxdotcc:dev Oct 4, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants