-
-
Notifications
You must be signed in to change notification settings - Fork 193
feat: Added a handler for the Voice Channel Effect Send event #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Also, whoever's reviewing this, in the Discord server I've brought up removing the return ":" + std::string{name} + ":";As this is only done when the emoji doesn't have an ID. Therefore, it only adds the colons to unicode emojis and turns this: |
|
Renamed the title to comply with code convention |
I forgot about that, my bad |
Jaskowicz1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple IDE silly things
|
I was going to write about Line 57 in 6915904
Not sure if this is something we want to address now and go through later to sort, or if this is just something to ignore @braindigitalis @Mishura4? |
Jaskowicz1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Jaskowicz1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to make my previous comment an approval, whoops
D++ didn't support the Voice Channel Effect Send event until now.
Code change checklist