-
-
Notifications
You must be signed in to change notification settings - Fork 193
Fix: channel_invites_get incorrect endpoint #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I'm surprised this wasn't caught in our unit tests, but thank you for your first contribution! |
Jaskowicz1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Mishura4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Please sign the CLA as indicated in #1497 (comment) and we'll merge this.
|
@Mishura4 CLA has been signed by contributor, i've requested your review again 🫡 |
Sorry, I just pushed to the wrong branch.
fix
cluster::channel_invites_getincorrect endpoint.The third parameter (
minor) is an empty str"", resulting in the incorrect API endpoint:GET /api/v10/channels/{channel_id}GET /api/v10/channels/{channel_id}/invitesCode change checklist