Skip to content

Conversation

@ProjectSky
Copy link
Contributor

Sorry, I just pushed to the wrong branch.

fix cluster::channel_invites_get incorrect endpoint.

The third parameter (minor) is an empty str "", resulting in the incorrect API endpoint:

  • Actual: GET /api/v10/channels/{channel_id}
  • Expected: GET /api/v10/channels/{channel_id}/invites

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit eeaa09f
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68dfe947a4615100088d9520
😎 Deploy Preview https://deploy-preview-1497--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the code Improvements or additions to code. label Oct 3, 2025
@Jaskowicz1
Copy link
Contributor

I'm surprised this wasn't caught in our unit tests, but thank you for your first contribution!

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Please sign the CLA as indicated in #1497 (comment) and we'll merge this.

@Jaskowicz1 Jaskowicz1 requested a review from Mishura4 October 4, 2025 08:45
@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Oct 4, 2025

@Mishura4 CLA has been signed by contributor, i've requested your review again 🫡

@Mishura4 Mishura4 merged commit 7a5f6b0 into brainboxdotcc:dev Oct 4, 2025
39 checks passed
@ProjectSky ProjectSky deleted the dev branch October 4, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants