Skip to content

fix: remove dynamic spend limit configuration from sdk constructor #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

stephancill
Copy link
Contributor

@stephancill stephancill commented May 30, 2025

Summary

  • Removes the dynamicSpendLimit config option and enables it by default for sub accounts
  • Also removes the restriction that only enables it when auto sub accounts is enabled

How did you test your changes?

Manual testing, unit tests

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 30, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@montycheese montycheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removes the restriction that only enables it when auto sub accounts is enabled

Where is this change made?

@stephancill stephancill merged commit 4035e43 into master Jun 2, 2025
8 checks passed
@stephancill stephancill deleted the fix/remove-dynamic-spend-limit-config branch June 2, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants