Fix a bug when updating a JCR node property #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n charge the update or the creation of a node property. By using the Groovy syntaxic sugar node[propertyName], it is not the property of a JCR node that is set but the property of the Java object of Node (NodeImpl more exactly). So the bug is fixed by removing this code and by using simply the Node#setProperty method to perform the command. Take into account also the exisint node property can be a multivalued one when updating it with a single value.
Author
|
Hum ... closed but not merged. Any explanation please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the node set command: the Node#setProperty method already takes in charge the update or the creation of a node property. By using the Groovy syntaxic sugar node[propertyName], it is not the property of a JCR node that is set but the property of the Java object of Node (NodeImpl more exactly). So the bug is fixed by removing this code and by using simply the Node#setProperty method to perform the command.
Take into account of the case of a multivalued property.