Skip to content

webdav: fix range header formatting in relay request #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzur wants to merge 1 commit into
base: 9.2
Choose a base branch
from
Open

webdav: fix range header formatting in relay request #7987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
webdav: fix range header formatting in relay request 
An open-ended range like `bytes=0-` produced an invalid header
like "bytes=0-null", resulting in no data being transferred. This
patch implements support for open-ended ranges (`bytes=0-`) and
suffix ranges (`bytes=-500`).

References #7971

Signed-off-by: Martin Zurowietz <[email protected]>
  • Loading branch information
@mzur
mzur committed Dec 19, 2025
commit 28b4ad28870c5a9682ec66792751a61b75163d13
15 changes: 13 additions & 2 deletions modules/dcache-webdav/src/main/java/org/dcache/webdav/DcacheResourceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1793,8 +1793,19 @@ public void relayData(OutputStream outputStream, io.milton.http.Range range)
try {
connection.setRequestProperty("Connection", "Close");
if (range != null) {
connection.addRequestProperty("Range",
String.format("bytes=%d-%d", range.getStart(), range.getFinish()));
String rangeHeader;
Long start = range.getStart();
Long finish = range.getFinish();

if (start == null && finish != null) {
rangeHeader = String.format("bytes=-%d", finish);
} else if (start != null && finish == null) {
rangeHeader = String.format("bytes=%d-", start);
} else {
rangeHeader = String.format("bytes=%d-%d", start, finish);
}

connection.addRequestProperty("Range", rangeHeader);
}

connection.connect();
Expand Down