add onnxruntime custom op's backend #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
daquexian
reviewed
Feb 2, 2021
Owner
daquexian
left a comment
There was a problem hiding this comment.
Thanks for your great contribution! Overall it looks good to me. Some minor comments are posted.
onnxsim/__main__.py
Outdated
| input_shapes[name] = shape | ||
| input_shapes.update({name: shape}) | ||
|
|
||
| input_datas = dict() |
Owner
There was a problem hiding this comment.
input_data_paths is a better name
| input_shapes = {} | ||
| sess_options = rt.SessionOptions() | ||
| if custom_lib is not None: | ||
| if os.path.exists(custom_lib): |
Owner
There was a problem hiding this comment.
raise an exception if file named custom_lib does not exist
Contributor
Author
There was a problem hiding this comment.
that's great, i will add it
onnxsim/__main__.py
Outdated
| if args.input_data is not None: | ||
| for x in args.input_data: | ||
| pieces = x.split(':') | ||
| name, data = pieces[0], pieces[-1] |
Owner
There was a problem hiding this comment.
pieces[0] -> ':'.join(pieces[:-1])
daquexian
approved these changes
Feb 6, 2021
Owner
|
Thanks for your great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the previous pr to this