Skip to content

Add recommendation on what to do with DLPack read-only flag #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 1 commit into from
Feb 16, 2024
Merged

Add recommendation on what to do with DLPack read-only flag #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/array_api_stubs/_draft/array_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,12 @@ def __dlpack__(
This logic is also applicable to handling of the new ``dl_device`` and ``copy``
keywords.

DLPack 1.0 added a flag to indicate that the array is read-only
(``DLPACK_FLAG_BITMASK_READ_ONLY``). A consumer that does not support
read-only arrays should ignore this flag (this is preferred over
raising an exception; the user is then responsible for ensuring the
memory isn't modified).

.. versionchanged:: 2022.12
Added BufferError.

Expand Down