Skip to content

Conversation

@grosser
Copy link

@grosser grosser commented Jan 2, 2014

@dblock
Copy link
Owner

dblock commented Jan 2, 2014

This is good. You also need to update RELEASING and CHANGELOG. Just add a Next Release section.

@grosser
Copy link
Author

grosser commented Jan 2, 2014

done

RELEASING.rdoc Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work, the bump or release tasks don't get loaded in Rakefile, try rake -T and it won't give you these.

@dblock
Copy link
Owner

dblock commented Jan 3, 2014

I think Gemfile.lock shouldn't be checked in, this is a general practice for libraries. If any specific version of a library needs to be used, it should be specified in Gemfile as such. Add Gemfile.lock to .gitignore.

@grosser
Copy link
Author

grosser commented Jan 3, 2014

fixed.
I always keep my lockfile because I value my sanity ;)

On Fri, Jan 3, 2014 at 7:54 AM, Daniel Doubrovkine (dB.) <
[email protected]> wrote:

I think Gemfile.lock shouldn't be checked in, this is a general practice
for libraries. If any specific version of a library needs to be used, it
should be specified in Gemfile as such. Add Gemfile.lock to .gitignore.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-31531009
.

@dblock
Copy link
Owner

dblock commented Jan 3, 2014

~/source/syntax/dblock (grosser-release)$ rake bump:patch
Unable to find a file with the gem version

@grosser
Copy link
Author

grosser commented Jan 3, 2014

damn MAJOR/MINOR variables are not supported in bump, reverted that part

On Fri, Jan 3, 2014 at 8:27 AM, Daniel Doubrovkine (dB.) <
[email protected]> wrote:

~/source/syntax/dblock (grosser-release)$ rake bump:patch
Unable to find a file with the gem version


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-31533525
.

@dblock
Copy link
Owner

dblock commented Jan 3, 2014

This got rid of rake clean, rake rdoc and rake test (should be the default task, too). Please resurrect those.

@grosser
Copy link
Author

grosser commented Jan 3, 2014

yeah if you want all the old stuff then this pr does not make any sense :)

@grosser grosser closed this Jan 3, 2014
@grosser grosser deleted the release branch January 3, 2014 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants