Skip to content

Conversation

@AntonioVentilii
Copy link
Collaborator

@AntonioVentilii AntonioVentilii commented Oct 29, 2025

Motivation

Some users are defining their OISY accounts as minting accounts of ICRC tokens. So, they need to have specific flows dedicated in these cases: for example, to create a Mint transaction, the minting account must send tokens out, and it can happen without balance.

Changes

  • Check if the user is the minting account inside the IC send flow.
  • Ignore balance validation in IcSendAmount if positive.

Tests

A practical test below: I temporarily made the OISY wallet as minting account of a fake ICRC, and, with zero balance, sent to another wallet.

Screen.Recording.2025-11-06.at.21.35.58.mov

@AntonioVentilii AntonioVentilii marked this pull request as ready for review January 5, 2026 12:52
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner January 5, 2026 12:52
Copilot AI review requested due to automatic review settings January 5, 2026 12:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables OISY users who have their accounts configured as minting accounts for ICRC tokens to perform mint transactions without requiring balance validation. This is essential for minting accounts which need to send tokens (mint transactions) even when their balance is zero.

Key Changes

  • Added conditional balance validation bypass in the IC send flow when the user is identified as a minting account
  • Updated UI to enable outflow actions (send/convert buttons) for minting accounts even with zero balance
  • Added comprehensive test coverage for the new minting account send behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/frontend/src/icp/components/send/IcSendAmount.svelte Added early return in validation logic to skip balance checks when user is a minting account
src/frontend/src/lib/components/hero/HeroContent.svelte Modified outflow action disable logic to account for minting account status, allowing actions with zero balance
src/frontend/src/tests/icp/components/send/IcSendAmount.spec.ts Added test case verifying no balance error is shown for minting accounts with insufficient funds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AntonioVentilii AntonioVentilii added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit e683e59 Jan 5, 2026
84 checks passed
@AntonioVentilii AntonioVentilii deleted the feat-frontend/Do-not-validate-balance-if-user-is-minting-account branch January 5, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants