feat(frontend): Common derived store for network address store #10316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a common derived store networkAddressStore that provides the appropriate address store based on the currently selected network. This simplifies address management in components by consolidating network-specific address store selection logic into a single reusable derived store.
- Adds
networkAddressStorethat dynamically returns the correct address store (BTC, ETH, or SOL) based on the active network - Updates
BtcReceive.svelteandSolReceive.svelteto use the new common store instead of manually selecting network-specific stores - Adds comprehensive test coverage for all supported networks (Bitcoin mainnet/testnet/regtest, Ethereum/Sepolia/Base/Polygon, Solana mainnet/devnet/local)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frontend/src/lib/derived/network-address.derived.ts | Introduces networkAddressStore that selects the appropriate address store based on network ID using conditional logic for all supported networks |
| src/frontend/src/btc/components/receive/BtcReceive.svelte | Refactors to use networkAddressStore instead of manually selecting between BTC address stores |
| src/frontend/src/sol/components/receive/SolReceive.svelte | Refactors to use networkAddressStore and removes now-unnecessary imports |
| src/frontend/src/tests/lib/derived/network-address.derived.spec.ts | Expands tests to cover networkAddressStore for all supported networks with comprehensive test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is useful to have a common derived store for the current address store for the selected network.