refactor(frontend): Use built-in util isIOS from gix-cmp
#10317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to use the built-in isIOS utility from the @dfinity/gix-components library instead of a custom implementation, eliminating duplicate code.
- Replaced all usages of the local
isIosfunction withisIOSfrom@dfinity/gix-components - Removed the local
isIosimplementation fromdevice.utils.ts - Removed associated test cases for the removed function
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/routes/+layout.svelte |
Updated to import and use isIOS from @dfinity/gix-components for modal scroll locking logic |
src/frontend/src/lib/utils/device.utils.ts |
Removed the local isIos function implementation |
src/frontend/src/lib/components/ui/SkeletonText.svelte |
Updated to import and use isIOS from @dfinity/gix-components for animation control |
src/frontend/src/lib/components/ui/SkeletonLogo.svelte |
Updated to import and use isIOS from @dfinity/gix-components for animation control |
src/frontend/src/lib/components/ui/Logo.svelte |
Updated to import and use isIOS from @dfinity/gix-components for transition handling |
src/frontend/src/lib/components/tokens/TokensList.svelte |
Updated to import and use isIOS from @dfinity/gix-components for animation parameter configuration |
src/frontend/src/lib/components/hero/Balance.svelte |
Updated to import and use isIOS from @dfinity/gix-components for loading state animation |
src/frontend/src/lib/components/exchange/ExchangeBalance.svelte |
Updated to import and use isIOS from @dfinity/gix-components for loading state animation |
src/frontend/src/tests/lib/utils/device.utils.spec.ts |
Removed test cases for the deleted isIos function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Library
gix-componentsalready has anisIOSutil. We can remove the ones we created.