chore(frontend): Remove unused destroyCallback method from class AppWorker
#10344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-method-from-class-AppWorker
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused destroyCallback method from the AppWorker class, cleaning up dead code. The method was a no-op by default and was never overridden by any of the 11+ subclasses of AppWorker in the codebase.
Key Changes
- Removed the
destroyCallbackmethod definition fromAppWorkerclass - Removed the call to
destroyCallback()from thedestroy()method - Cleaned up related test code including the test spy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/frontend/src/lib/services/_worker.services.ts |
Removed unused destroyCallback method definition and its invocation in the destroy() method |
src/frontend/src/tests/lib/services/worker.services.spec.ts |
Removed test spy and override for the now-deleted destroyCallback method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenysKarmazynDFINITY
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Method
destroyCallbackis not used anywhere anymore in the instances ofAppWorker. So we can remove it.