chore(core): generate DID declarations with icp-sdk/bindgen #10409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
AntonioVentilii
approved these changes
Nov 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
# Motivation As a follow-up of #10409, we can clean-up the scripts that generates the certified types. # Notes `@icp-sdk/bindgen` is less verbose than `dfx generate` in terms of files generated. That's why we do not need to remove some files in post-processing. # Changes - Update `did.update.types.mjs` Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…10417) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is the first step. --------- Co-authored-by: Copilot <[email protected]>
This was referenced Nov 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…dings (#10429) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `xtc_ledger` bindings that was done in PR #9559
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…gs (#10431) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `sol_rpc` bindings that was done in PR #9560
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
#10432) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `signer` bindings that was done in PR #9561
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…gs (#10433) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `rewards` bindings that was done in PR #9562
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…10434) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `llm` bindings that was done in PR #9563
AntonioVentilii
added a commit
that referenced
this pull request
Nov 20, 2025
…y` bindings (#10436) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `icp_swap_factory` bindings that was done in PR #9566
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…indings (#10435) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `kong_backend` bindings that was done in PR #9564
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…bindings (#10437) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `icp_swap_pool` bindings that was done in PR #9567
daviddecentage
pushed a commit
that referenced
this pull request
Nov 20, 2025
…gs (#10428) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `backend` bindings that was done in PR #9565 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
# Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is the last step: we reinstate the removal of the subfolder `declarations`. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Nov 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…indings (#10448) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `ext_v2_token` bindings.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…dings (#10447) # Motivation With the new bindings generation script (PR #10409), we prefer to not have the subfolder `declarations` that bindgen creates, but to consolidate the bindings in the same folder. However, our current imports are using such subfolder. The plan is: - Undo the removal of the subfolder (temporarily). - Adapt all the imports to use the "old" main folder for declarations (split in a few PRs, since it is quite a lot of changes). - Re-remove the subfolder. This PR is part of the second step: we undo the reference to subfolder for the `gldt_stake` bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to migrate to
@icp-sdk/bindgenfor generating the IDL factory declarations for following reasons:Changes
@icp-sdk/bindgenas a dev dependencydfx generatewith a function using bindgen ingenerate.sh