Skip to content

Conversation

@AntonioVentilii
Copy link
Collaborator

Motivation

We noticed that the list extracted from nftGeek not necessarily contains only "active" collections. Quite a lot of them are inactive canisters (for example out of cycles).

So, we can simply remove it from our curated list for now.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes nftGeek as a source for EXT canister collections due to the list containing inactive collections (e.g., canisters out of cycles). The change simplifies the collection fetching logic by removing all nftGeek-related code and data.

  • Removes the nftGeek API URL constant and all related fetching/parsing functions from the build script
  • Removes approximately 200+ collection entries from the tokens.ext.json file that were sourced from nftGeek
  • Updates one collection name from "BAD 3D Avatars" to "B.A.D 3D Avatars" (appears to be an intentional correction)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/frontend/src/env/tokens/tokens-ext/tokens.ext.json Removes ~200+ inactive NFT collection entries that were sourced from nftGeek; includes one name correction for "B.A.D 3D Avatars"
scripts/build.tokens.ext.ts Removes nftGeek API URL constant, query/parse functions, and integration from collection merging logic
Comments suppressed due to low confidence (1)

scripts/build.tokens.ext.ts:62

  • The unused interfaces NftGeekResponseData and NftGeekCollectionsResponseData should be removed since all nftGeek-related functionality has been deleted.
interface NftGeekResponseData {
	canisterId: string;
	name: string;
	alias: string;
	interface: string;
}

interface NftGeekCollectionsResponseData {
	collections: NftGeekResponseData[];
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AntonioVentilii AntonioVentilii added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 6f701f7 Nov 25, 2025
80 checks passed
@AntonioVentilii AntonioVentilii deleted the feat-build/Remove-nftGeek-from-sources-of-EXT-canister-collections branch November 25, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants