feat(frontend): Util to extract the fee from tokens in ICP network #10672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a utility function to centralize fee extraction logic for tokens in the ICP network, addressing the difference between EXT v2 tokens (which have zero fees) and other supported standards (ICP, ICRC, DIP20) that have embedded fees.
Key changes:
- Created
getTokenFeeutility function that returns zero for EXT v2 tokens, extracts the fee for ICP/ICRC/DIP20 tokens, and returns undefined for non-ICP token standards - Refactored
IcTokenFeeandIcSendAmountcomponents to use the new utility instead of direct type casting toOptionIcToken - Added comprehensive test coverage for the new utility function and updated component tests
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/icp/utils/token.utils.ts | New utility function getTokenFee that centralizes fee extraction logic based on token standard |
| src/frontend/src/tests/icp/utils/token.utils.spec.ts | Comprehensive test suite for the new utility function covering all token standards |
| src/frontend/src/icp/components/fee/IcTokenFee.svelte | Refactored to use getTokenFee utility instead of type casting |
| src/frontend/src/icp/components/send/IcSendAmount.svelte | Refactored to use getTokenFee utility instead of type casting |
| src/frontend/src/tests/icp/components/fee/IcTokenFee.spec.ts | Added test case for EXT token fee rendering and improved test structure with beforeEach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenysKarmazynDFINITY
approved these changes
Dec 3, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tokens EXT have zero fee, while the other standards the we support in ICP network have their imbedded fee. To centralize the logic, we create an util to extract the fee based on the standard.