Skip to content

Conversation

@AntonioVentilii
Copy link
Collaborator

Motivation

We are going to transform the standard field of a Token type from an enum to an object (so that we can extend it with other fields like version or subStandards).

So, we can simply define the standard of EXT tokens as ext and specify the version after.

@AntonioVentilii AntonioVentilii marked this pull request as ready for review December 12, 2025 13:34
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner December 12, 2025 13:34
Copilot AI review requested due to automatic review settings December 12, 2025 13:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the EXT token standard from 'extV2' to 'ext' across the frontend codebase. This change prepares for a future refactoring where the standard field will be transformed from an enum to an object, allowing for additional fields like version or subStandards.

Key Changes

  • Updated token standard definition from 'extV2' to 'ext' in the schema
  • Renamed utility functions from isTokenExtV2/isTokenExtV2CustomToken to isTokenExt/isTokenExtCustomToken
  • Updated all references to the standard value and utility functions across test files and implementation code

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/frontend/src/lib/schema/token.schema.ts Changed token standard enum value from 'extV2' to 'ext'
src/frontend/src/icp/utils/ext.utils.ts Renamed utility functions isTokenExtV2isTokenExt and isTokenExtV2CustomTokenisTokenExtCustomToken, updated standard value in mapExtToken
src/frontend/src/icp/utils/token.utils.ts Updated import and usage of renamed isTokenExt function
src/frontend/src/icp/utils/ic-send.utils.ts Updated import and usage of renamed isTokenExt function
src/frontend/src/icp/services/nft-send.services.ts Updated import and usage of renamed isTokenExt function
src/frontend/src/icp/services/ext.services.ts Updated standard value from 'extV2' to 'ext' in token mapping
src/frontend/src/lib/utils/tokens.utils.ts Updated import and two usages of renamed isTokenExt function
src/frontend/src/lib/utils/nft.utils.ts Updated import and two usages of renamed isTokenExt function
src/frontend/src/lib/stores/default-tokens.store.ts Updated import and usage of renamed isTokenExt function
src/frontend/src/lib/stores/custom-tokens.store.ts Updated import and usage of renamed isTokenExt function
src/frontend/src/lib/services/nft.services.ts Updated import and usage of renamed isTokenExtCustomToken function
src/frontend/src/lib/components/tokens/EnableTokenToggle.svelte Updated import and usage of renamed isTokenExtCustomToken function
src/frontend/src/tests/mocks/ext-tokens.mock.ts Updated mock token standard values from 'extV2' to 'ext'
src/frontend/src/tests/lib/stores/custom-tokens.store.spec.ts Updated test mock standard value from 'extV2' to 'ext'
src/frontend/src/tests/lib/schema/token.schema.spec.ts Updated test mock standard value from 'extV2' to 'ext'
src/frontend/src/tests/icp/utils/ext.utils.spec.ts Renamed test suite and updated imports/usages of renamed functions and standard values
src/frontend/src/tests/icp/services/ext.service.spec.ts Updated test mock standard values from 'extV2' to 'ext'
src/frontend/src/tests/icp/services/ext-add-custom-tokens.service.spec.ts Updated test mock standard value from 'extV2' to 'ext'
src/frontend/src/tests/icp/schema/ext-token.schema.spec.ts Updated test mock standard value from 'extV2' to 'ext'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AntonioVentilii AntonioVentilii added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 4f5f967 Dec 12, 2025
78 checks passed
@AntonioVentilii AntonioVentilii deleted the feat-frontend/Rename-standard-for-EXT-tokens branch December 12, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants