-
Notifications
You must be signed in to change notification settings - Fork 39
feat(frontend): New Video component #10893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new Video component to enable rendering of video media URLs for NFTs. The component is designed to mirror the existing Img component structure, providing similar styling and configuration options but adapted for video elements.
Key Changes:
- New Video component in the UI component library with props for styling, accessibility, and event handling
- Support for autoplay, loop, and muted video playback
- Consistent prop interface with other media components (grayscale, rounded, fitHeight, etc.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenysKarmazynDFINITY
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some basic tests for the component.
Otherwise, LGTM, thanks.
Co-authored-by: Copilot <[email protected]>
Motivation
We will allow to render video media URLs for NFTs. So, first we need a basic
Videocomponent.