feat(frontend): Add legacy tokens endpoint to EXT tokens
#10932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the legacy tokens endpoint in EXT v2 token canisters to handle canisters that don't support the newer tokens_ext method. The implementation provides a new getTokensByOwnerLegacy method that calls the legacy tokens canister method and returns a simple array of token indices.
- Added
getTokensByOwnerLegacymethod toExtV2TokenCanisterclass - Implemented comprehensive test suite for the new legacy method
- Maintains consistent error handling patterns with existing methods
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frontend/src/icp/canisters/ext-v2-token.canister.ts | Added getTokensByOwnerLegacy method that calls the legacy tokens canister endpoint and handles responses (including the "No tokens" edge case) |
| src/frontend/src/tests/icp/canisters/ext-v2-token.canister.spec.ts | Added comprehensive test suite covering success cases, error handling, and edge cases for getTokensByOwnerLegacy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenysKarmazynDFINITY
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some EXT token canisters do not support the newest method for transfer
tokens_ext, so, we need to fallback on the legacy one if needed. In this PR, we access the canister method for legacy tokens.Note that the methods are actually equivalent, just different names.