feat(frontend): Different labels for Burn transaction in Send flow #11006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for displaying different labels when a transaction is detected as a "Burn" operation - when tokens are being sent to the minting account. The implementation adds a new burning parameter that is derived based on the destination address matching the token's minting account, and updates wizard step titles to show "Burn" and "Burning..." instead of "Send" and "Sending..." when appropriate.
Key Changes:
- Added
burningparameter to send wizard configuration with priority order: minting > burning > converting - Added burn-specific i18n translations (burn, burning, burn_review_subtitle)
- Implemented burning detection in SendModal by comparing destination with minting account
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/src/lib/config/send.config.ts |
Added burning parameter to wizard steps configuration with conditional title logic for burn operations |
src/frontend/src/lib/i18n/en.json |
Added burn-specific translation keys for UI labels |
src/frontend/src/lib/components/send/SendModal.svelte |
Implemented burning detection logic and passed it to wizard steps |
src/frontend/src/tests/lib/config/send.config.spec.ts |
Added comprehensive test coverage for burning scenarios and priority handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…saction-in-Send-flow
DenysKarmazynDFINITY
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we can know the minting of an account, we can now check if the transaction will be a Burn transaction and inform the user accordingly.