update URLs to download data from dgraph-benchmarks repo #9404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the URLs used for downloading data from the dgraph-benchmarks repository. It replaces GitHub blob URLs with raw and media URLs for schema and RDF files and updates the base URL used for LDBC files.
- Updated datafiles map with new raw/media URL patterns
- Changed the baseUrl for LDBC files to the media.githubusercontent.com endpoint
- Simplified the assignment in the downloadLDBCFiles function
Comments suppressed due to low confidence (2)
t/t.go:884
- The updated URLs in the datafiles map use different hostnames (raw.githubusercontent.com for some files and media.githubusercontent.com for others). Please ensure the differences are intentional (e.g., based on file type) and document the reasoning if necessary.
"1million-noindex.schema": "https://raw.githubusercontent.com/hypermodeinc/dgraph-benchmarks/refs/heads/main/data/1million-noindex.schema",
t/t.go:891
- Since the new baseUrl no longer uses the GitHub blob interface, verify that appending the query parameter suffix ('?raw=true') in subsequent URL constructions is still required, or adjust if not needed.
var baseUrl = "https://media.githubusercontent.com/media/hypermodeinc/dgraph-benchmarks/refs/heads/main/ldbc/sf0.3/ldbc_rdf_0.3/"
ghost
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.