Skip to content

Update openapi.yml #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update openapi.yml #72

wants to merge 1 commit into from

Conversation

jidanni
Copy link

@jidanni jidanni commented Feb 10, 2023

In https://meta.discourse.org/t/allow-api-use-by-regular-users-not-just-admins/254724/ regular user Dan Jacobson lost hope thinking that only admins could make use of the API.

In https://meta.discourse.org/t/allow-api-use-by-regular-users-not-just-admins/254724/ regular user Dan Jacobson lost hope thinking that only admins could make use of the API.
@CvX CvX requested a review from oblakeerickson February 10, 2023 11:46
@oblakeerickson
Copy link
Contributor

oblakeerickson commented Feb 10, 2023

I like the idea of this, and I'd be open to updating the wording. However, without support from admins and an approved endpoint in the user api keys site settings "regular users" still can't just generate their own api keys.

I'm going to close this though as any change to the api docs actually needs to be in the discourse/discourse repo. From the README:

Please do not manually edit the openapi.yml or openapi.json files located in this repo. These files must be edited from the rswag files located in

https://github.com/discourse/discourse/tree/main/spec/requests/api

Text changes can be applied to this file: https://github.com/discourse/discourse/blob/main/spec/swagger_helper.rb

@jidanni
Copy link
Author

jidanni commented Feb 11, 2023

OK. I didn't want to link to faraway URLs anyway. I'll drop the issue.
P. S., all I know is a GitHub search brought me to that file, that I wish had a 'do not edit' warning right there in the header.

@jidanni jidanni deleted the patch-1 branch February 11, 2023 01:11
@jidanni
Copy link
Author

jidanni commented Feb 19, 2023

https://meta.discourse.org/t/allow-api-use-by-regular-users-not-just-admins/254724/6 has some more info on what maybe should get written. All this is over in my head of course so I'll just kind of step out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants