Skip to content

[main] [release/10.0-preview1] Do not remove wixpacks from items to sign #60524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[main] [release/10.0-preview1] Do not remove wixpacks from items to sign #60524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not remove wixpacks from items to sign They need to be in the list… 
… so that they are identified as the pack for an msi or exe that can be unpacked, signed, and then used to re-create the msi/exe.
  • Loading branch information
@mmitche
mmitche authored and github-actions committed Feb 20, 2025
commit 3478177a95ba2be002fcd1b3ef16da9af4696416
2 changes: 0 additions & 2 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
<ItemsToSign Include="$(VisualStudioSetupOutputPath)**\*.vsix" />
<ItemsToSign Include="$(ArtifactsDir)installers\$(Configuration)\**\*.exe" />
<ItemsToSign Include="$(ArtifactsDir)installers\$(Configuration)\**\*.msi" />
<ItemsToSign Remove="$(ArtifactsDir)installers\$(Configuration)\**\*.wixpack.zip" />
<ItemsToSign Remove="$(ArtifactsPackagesDir)**\*.wixpack.zip" />
<ItemsToSign Remove="$(ArtifactsPackagesDir)**\*symbols.nupkg" />
</ItemGroup>

Expand Down
Loading