Skip to content

Make Onnx path parameter mandatory in OnnxConverter #423

Closed

Description

@zeahmed

According to the documentation, both Onnx and Json paths are optional. Make at least Onnx path mandatory for conversion.

https://github.com/dotnet/machinelearning/blob/master/src/Microsoft.ML/Models/OnnxConverter.cs

OnnxConverter converter = new OnnxConverter()
{
    InputsToDrop = new[] { "Label" },
    OutputsToDrop = new[] { "Label", "Features" },
    Onnx = onnxPath,
    Json = onnxAsJsonPath,
    Domain = "Onnx"
};

converter.Convert(model);

Activity

  1. added this to the 0718 milestone on Jun 28, 2018
  2. self-assigned this
    on Jul 10, 2018
  3. modified the milestones: 0718, 0818 on Aug 4, 2018
  4. ghost locked as resolved and limited conversation to collaborators on Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions