Skip to content

Remove legacy dependency from TextLoaderTests.cs - #2033

Merged
codemzs merged 6 commits into
dotnet:masterfrom
artidoro:textloader
Jan 5, 2019
Merged

codemzs merged 6 commits into
dotnet:masterfrom
artidoro:textloader

Conversation

@artidoro

@artidoro artidoro commented Jan 5, 2019

Copy link
Copy Markdown
Contributor

Part of the effort described in #1971.

This PR removes references to the legacy API from the TextLoaderTests.cs file.
Part of the tests just required substituting to the new textloader, others were substituted by an equivalent json entrypoint graph that was used to run the same pipeline defined in the old api.

@artidoro artidoro self-assigned this Jan 5, 2019

@codemzs codemzs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin wschin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs
codemzs merged commit 496e185 into dotnet:master Jan 5, 2019
@artidoro
artidoro deleted the textloader branch February 4, 2019 19:48
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants