Repository navigation
Update release for 0.9 - #2067
Merged
Merged
Conversation
* attempt to separate out TextLoaderStatic * fix failing tests (ReturnTypeIsSchemaShapeChained) * moving TextLoaderStatic to the Microsoft.ML.StaticPipe assembly * Add MLNetStaticPipeReference to get Analyzer Tests happy * Moving remaining static extensions to the microsoft.ML.StaticPipe assembly * fix access modifier instead of adding BestFriend attribute * Fix TextLoader bug * fix build break (caused by bad merge with master in previous commit) * review comment - maintain consistency, removing license text from sample files * review comment - update newly added tests
1. Remove ISchema interface 2. Rename CompositeSchema to ZipBinding
* Update Iris tests to use new API * review comments * review comments -2 . made couple of classes private * removed dummy initialization, and using properties instead
* API changes for GPU support * update to test package on nuget.org * Addressed PR comments * Addressed PR comments * Point to nuget on myget.org * restore directory.build.props
* update PredictClusters test; delete a couple of skipped tests * delete couple of additional helper files (which were being used for skipped tests) * remove Legacy references from Microsoft.ML.TestFramework.csproj and EnvironmentExtensions.cs * fix EntryPointCatalog test
* Remove ColumnType.IsBool * Remove ColumnType.IsPrimitive * Remove ColumnType.IsNumber * Remove ColumnType.IsText * Move ColumnType.IsStandardScalar to an extension method.
* Added more documentation and extra CPU path test * minor change to kick off build
* Remove Legacy dependency from Microsoft.ML.Benchmarks * Use model.Transform for batch prediction benchmarks * Removing #pragma warning disable * Using one mlContext for both training and prediction
…2015) * Remove legacy API test that already have coverage and refactor code. * PR feedback.
* remove legacy from textloader need to test with build fix * fixed test * review comments * updated exception test and answered review comments * exception * fixed typo
* Prototype of new ONNX converter and an end-to-end test * Reuse existing code to do conversion and polish a test * Test Kmeans as well * 1. Introduce ONNX conversion as an extention to MLContext 2. Address minor comments Remove two best friends * Add test comparison * Address comments * Propose another domain name * Add missing header * One more test for one-hot encoding's conversion * Add one more test * Add logistic regression test * Add LightGBM test * Test NaN replacement and fix build for core30 and x86 * Add one more test * Update Kmeans file due to change of initialization * Add a test for onnx conversion cmd * Add word embedding test * Remove old tests * increase tol * Drop version in saved baseline file * make c30 happy * Make c30 happier * c30 needs even more
…2036) * Expose internal APIs to components in internal repo * Address code review comments
codemzs
approved these changes
Jan 8, 2019
codemzs
left a comment
Member
There was a problem hiding this comment.
Cloned your repo, built the packages locally and ran a simple SDCA example using Microsoft.ML nuget and it ran without any issues.
Member
|
Just an FYI - since this .csproj is not targeting a NuGet package, we are no longer shipping the "static API". /cc @TomFinley Refers to: src/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.csproj:3 in 7e28d21. [](commit_id = 7e28d21, deletion_comment = False) |
Member
|
REMINDER: Don't squash this. |
Contributor
Whoops... we should ultimately put them in a new nuget, but unshipping them altogether is not a good story. I have a small issue #2072 to address this right now, Or perhaps just making a new nuget! That also works. 😛 Per #1076. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the release branch for 0.9