Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dragonflydb/dragonfly
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a16b199767014bbad4743864e878608ba4c7d433
Choose a base ref
...
head repository: dragonflydb/dragonfly
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3f01fdd55378402301dfe60fe1f6f4e6611d4a86
Choose a head ref
  • 18 commits
  • 40 files changed
  • 6 contributors

Commits on Apr 26, 2025

  1. feat: allow sharding by cluster slot id (#5006)

    This is relevant only for cluster-enabled configurations.
    Also, inline the cluster config getter functions, as they are on critical path for 100% of requests.
    
    Finally, skip a test that triggers a check-fail bug filed in #5004
    
    Fixes #5005
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 26, 2025
    Configuration menu
    Copy the full SHA
    d5c3752 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2025

  1. fix: potential crash with multi-sharded pfmerge (#5008)

    Fixes #5004
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 27, 2025
    Configuration menu
    Copy the full SHA
    ff7d9b7 View commit details
    Browse the repository at this point in the history
  2. chore: Pipelining fixes (#4994)

    Fixes #4998.
    1. Reduces agressive yielding when reading multiple requests since it humpers pipeline efficiency.
       Now we yield consistently based on cpu time spend since the last resume point (via flag with sane defaults).
    2. Increases socket read buffer size effectively allowing processing more requests in bulk.
    
    `./dragonfly  --cluster_mode=emulated`
    latencies (usec) for pipeline sizes 80-199:
    p50: 1887, p75: 2367, p90: 2897, p99: 6266
    
    `./dragonfly  --cluster_mode=emulated --experimental_cluster_shard_by_slot`
    latencies (usec) for pipeline sizes 80-199:
    p50: 813, p75: 976, p90: 1216, p99: 3528
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 27, 2025
    Configuration menu
    Copy the full SHA
    6d30baa View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2025

  1. Configuration menu
    Copy the full SHA
    59a347d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d373187 View commit details
    Browse the repository at this point in the history
  3. chore: clean ups around command squasher (#5011)

    1. Eliminate replies reverse call - will allow to unite replies and cmd vectors into one.
    2. Introduce SwitchTxCmd function to avoid code duplication.
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    d7a7591 View commit details
    Browse the repository at this point in the history
  4. chore: StoredCmd to support both owned and external arguments (#5010)

    Before: StoredCmd always copied the backing buffer of the commands.
    this of course sub-optimal if the bucking buffer exists during the life-time
    of StoredCmd. This is exactly the case in `Service::DispatchManyCommands`.
    
    This PR:
    1. Adds support for both owned and non-owned arguments.
    2. Improves the interfaces around StoredCmd and removes some code duplication.
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    0f415ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa7e8ab View commit details
    Browse the repository at this point in the history
  6. fix: regtest failures (#5013)

    1. Fix a crash bug in RESETSTAT when number of shards is less than number of threads.
    2. Tune regtests parameters for pipelining tests to pass.
    
    Signed-off-by: Roman Gershman <[email protected]>
    romange authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    23e6db9 View commit details
    Browse the repository at this point in the history
  7. fix(glob): Correctly match longer strings with '*' or '**' pattern (#…

    …5001)
    
    * fix(glob): Correctly match longer strings with '*' or '**' pattern
    
    If string is longer than 16 chars we are using reflex library for
    matching. When used pattern is '*' or '**' we are going to remove
    trailing and leading star and have empty pattern. We should, in this,
    edge case set manually star pattern.
    
    Fixes #4948
    
    Signed-off-by: mkaruza <[email protected]>
    
    * Core matching test
    
    ---------
    
    Signed-off-by: mkaruza <[email protected]>
    mkaruza authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    98fb8fb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5ea3070 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2128eb3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    70be62c View commit details
    Browse the repository at this point in the history
  11. chore: polishing. put basic usage info to stdout using one call to a …

    …void messing lines (#5019)
    
    chore: polishing. put basic usage info to stdout using one call to avoid messing with lines
    vyavdoshenko authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    23d310b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2025

  1. Configuration menu
    Copy the full SHA
    880cd8d View commit details
    Browse the repository at this point in the history
  2. feat(pytest): Generate command with huge value strings in seeder (#4957)

    Generate command with long strings. We will first create number of
    random samples that will be used to match keys for which we are generating huge 
    strings. Total length of huge value string will be divided equally between elements in
    generated command.  
    
    Closes #4430
    
    Signed-off-by: mkaruza <[email protected]>
    mkaruza authored Apr 29, 2025
    Configuration menu
    Copy the full SHA
    13d8062 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2025

  1. Configuration menu
    Copy the full SHA
    f35c89b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f01fdd View commit details
    Browse the repository at this point in the history
Loading