Skip to content

[WIP] test: add dragonfly_db fixture to python tests #199 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shmulik-klein
Copy link
Contributor

@shmulik-klein shmulik-klein commented Jul 12, 2022

Signed-off-by: Shmulik Klein [email protected]

  • Add dragonfly_db fixture
  • Parse tests requirements and pass as flags to the executable
  • Flush all data

@romange
Copy link
Collaborator

romange commented Jul 12, 2022

Are you planning to complete both tasks in this PR?

@shmulik-klein
Copy link
Contributor Author

@romange I prefer to break it into three PRs - this one, the one that parse the flags and another one which flushes all data

@romange
Copy link
Collaborator

romange commented Jul 12, 2022

LGTM, but can you expand on "the one that parse the flags" part? What do you mean? I imagine that we run the test suiteonce and it will make sure to run executables in different configurations according to the parameter requirements tests inside it. I hope it's possible to do it using parametrized fixtures.

@romange romange merged commit 1f2895e into dragonflydb:main Jul 12, 2022
@shmulik-klein
Copy link
Contributor Author

@romange I'll move the discussion into the #199 thread. Overall, yes that's what the bullet refers too - taking the test requirement and pass it as flags part of the binary execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants