fix: Support for additional flags in expireat, pexpire and pexpireat commands #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Apr 26, 2025
src/server/generic_family_test.cc
Outdated
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| #include "server/generic_family.h" | |||
|
|
|||
| #include "absl/strings/str_format.h" | |||
There was a problem hiding this comment.
you do not need to use a real clock for these tests. please take a look at AdvanceTime helper function. This is how we control time in our unit tests
romange
reviewed
Apr 26, 2025
|
Original issue didn't mention HEXPIRE command, would it be possible to also expire options for it as well? |
|
Lets separate - it's too different things. if you need for HEXPIRE - please open an issue and explain your use-case. |
|
@romange I have replaced the actual clock with test clock in test cases and updated the PR. can you please review it once? |
romange
approved these changes
Apr 30, 2025
|
Thank you @H4R5H1T-007 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4829