Check requirements before running updatedb#2708
Conversation
| update_fix_compatibility(); | ||
|
|
||
| // Check requirements before updating. | ||
| if (!drush_update_check_requirements()) { |
There was a problem hiding this comment.
Maybe this should be a validation callback instead, so it's run before we hit the actual command? Then drush_update_check_requirements can just be used directly or the validation command can call out to that as the code is now.
There was a problem hiding this comment.
Well then we have to go through the rigmarole of loading all the .install files in the validation
|
I get that update.php does this, but updatebd doesnt have to do everything that update.php does. updatedb lacks tests and i'm loath to put more weight on it without tests. |
|
The problem is that drush will run updates when core would not. |
|
Right. Some other command could validate requirements and then careful folks would chain calls to that command and then updatedb. Just saying that updatedb doesn't have to do it all. |
|
Merged into 8.x and master in order to help media entity contrib project. |
|
Thanks! |
|
When is the next release due? |
|
This still does not work on a Drupal 7 site. The Issue #1427 was closed in favour of this ticket, but the bug is still present. |
See #1427